[security] Slightly improve CSP header #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
security
oliviertassinari
force-pushed
the
csp-baseline
branch
from
5dece8d
to
f754359
Compare
|
The problem seems to be that the iframe lives on about:blank which likely has some elevated policies being a chromium internal page. I didn't investigate deeper, just changed the test to go to https://example.com first and now it seems to pass. |
Janpot
approved these changes
Jul 6, 2024
|
Oh, I didn't think about this. You nailed it 👍, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A starting point for a CSP rule with permissive rules that we can narrow down overtime: https://stackoverflow.com/questions/35978863/allow-all-content-security-policy
Context: https://groups.google.com/a/mui.com/g/team-store/c/6tkWMOQ2ho0.